Add a setting for enabling iterator caching #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
force-pushed
the
iterators
branch
from
c58327b to
86948d3
Compare
danlamanna
force-pushed
the
iterators
branch
from
86948d3 to
c628d5a
Compare
|
@Andrew-Chen-Wang Thoughts on this? |
|
Gentle bump - any updates on this? |
Comment on lines
-247
to
-249
| with self.assertNumQueries(1): | ||
| with self.assertNumQueries(2): | ||
| data1 = list(Test.objects.iterator()) | ||
| with self.assertNumQueries(0): |
There was a problem hiding this comment.
why did you remove these assertions?
There was a problem hiding this comment.
I don't think I did. Since I defaulted the setting to False this should run 2 queries. The below block now does what this block did before.
|
lgtm thank you |
|
thx for this. I don't think it's a breaking change albeit a changing behavior. As they say, don't add performance improvements until you notice performance hits. If people notice a slowdown, I'm sure they can check the CHANGELOG to see this change and re-enable the setting. |
danlamanna
added a commit
to ImageMarkup/isic
that referenced
this pull request
Jan 16, 2025
The latest version of django-cachalot disables caching iterators by default. See noripyt/django-cachalot#263.
danlamanna
added a commit
to ImageMarkup/isic
that referenced
this pull request
Jan 21, 2025
The latest version of django-cachalot disables caching iterators by default. See noripyt/django-cachalot#263.
danlamanna
added a commit
to ImageMarkup/isic
that referenced
this pull request
Jan 21, 2025
The latest version of django-cachalot disables caching iterators by default. See noripyt/django-cachalot#263.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256
Description
This adds a setting to enable caching query results when they're generators.
Rationale
Caching iterators causes OOM errors as documented in #256 when using
QuerySet.iteratorfor large result sets because of list coercion.I defaulted this setting to
Falsesince I think that's less surprising behavior, but this does change the existing behavior, so it would be a breaking change. Let me know if I should invert it to cache iterators by default as it currently does.